Proposition: new Connection API (replace RxBleConnection)
#239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It aims to provide a more concise API that utilises newer `RxJava 1` API like `Single` and `Completable` as well as a clean extension point for future functionality “knobs”.
…ture unsubscription.
…, `Completable`) with possibility of managed radio behaviour.
This was referenced Jul 27, 2017
dariuszseweryn
added a commit
that referenced
this pull request
Aug 3, 2017
…lishConnection(SetupOptions)` (#240 #224) This new function is a perfect extension point to introduce a new public API #239 which will return the new API without changing the Major version number. Till then all new public classes were moved to the `internal` package and should not be publicly available.
…nection discoverServices() return type. Removed specialized discoverService(DiscoverySetup).
Closed
…new_connection_api
4 tasks
…d TrueFalseAuto enum for setup classes.
|
This was mentioned as being part of the 1.5.0 release. Is that still the plan? |
|
I don't think so, I think we'll postpone it. It looks like there will be 1.5.0, then RxJava2, then new API. Am I right @dariuszseweryn ? |
|
This will not be included in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It aims to provide a more concise API that utilises newer
RxJava 1API likeSingleandCompletableas well as a clean extension point for future functionality “knobs”.This Pull Request is made to ignite a discussion about the future API.