Separated command queues between connections #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(#250) It was found that commands from different `BluetoothGatt`’s are synchronized so it is possible to decouple synchronization of commands for different connections. Thanks to that if there are two or more connections opened and one connection would get stalled — other connections may continue to work without stalling — with a single command queue shared between connections it was not possible.
|
Can someone merge this pull request? |
|
It still requires some slight changes but you can expect it will arrive soon. |
|
Cool!!!
Thanks for your help.
Osvaldo.
…On Tue, Aug 15, 2017 at 4:06 PM, Paweł Urban ***@***.***> wrote:
It still requires some slight changes but you can expect it will arrive
soon.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#260 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXiMtJ7c-5TyiL90dt2wWTGq4VHCJUmks5sYghrgaJpZM4Osmk0>
.
--
*Osvaldo Mercado Espinel*
Mobile Developer Senior *|* Koombea
*T:* + (57) 313 518 2756 - 300 393 7851
*skype:* osmer_jr *|* *twitter:* @osvaldomercado
*W:* www.koombea.com
<http://www.koombea.com/>
|
… from leaking out of the ConnectionComponent.
…operations should not mention "radio" from now on.
…interface and added a renamed equivalent.
uKL
requested changes
Aug 22, 2017
| @@ -52,7 +51,7 @@ public void run() { | |||
|
|
|||
| @Override | |||
| @RestrictTo(RestrictTo.Scope.LIBRARY_GROUP) | |||
| public <T> Observable<T> queue(final Operation<T> operation) { | |||
| public synchronized <T> Observable<T> queue(final Operation<T> operation) { | |||
There was a problem hiding this comment.
I'm not sure if synchronization is required here. The only thing this method does it creating an Observable instance. It doesn't have to be synchronized (no shared resources)
…Operation)` function.
|
were the code changes requested approved? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(#250) It was found that commands from different
BluetoothGatt’s are synchronized so it is possible to decouple synchronization of commands for different connections. Thanks to that if there are two or more connections opened and one connection would get stalled — other connections may continue to work without stalling — with a single command queue shared between connections it was not possible.