Terminate ConnectionOperationQueue with proper exception #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As long as the user is interested in the connection the `ConnectionOperationQueue` will check the `DisconnectionRouterOutput` for exceptions that cause disconnection. If this exception is emitted the `ConnectionOperationQueue` terminates itself with the emitted error. If the user unsubscribes from the `RxBleDevice.establishConnection()` then the `ConnectionOperationQueue` terminates itself with the `BleDisconnectedException` as it was before this change.
dariuszseweryn
changed the title
uKL
requested changes
Oct 25, 2017
| .queue(operationDisconnect) | ||
| .subscribe( | ||
| Actions.empty(), | ||
| Actions.<Throwable>toAction1(Actions.empty()) | ||
| ); | ||
| } | ||
|
|
| } | ||
| }), | ||
| disconnectionErrorOutputObservable = Observable.merge( | ||
| disconnectionErrorInputRelay, | ||
| adapterStateObservable |
There was a problem hiding this comment.
Can we have it extracted to emitErrorWhenAdapterIsDisabled or similar?
| } | ||
| }), | ||
| disconnectionErrorOutputObservable = Observable.merge( | ||
| disconnectionErrorInputRelay, | ||
| adapterStateObservable |
There was a problem hiding this comment.
Shouldn't it rely on the initial state as well?
There was a problem hiding this comment.
Was not an issue till now. The DisconnectionRouter would not get created (@ConnectionScope) if the adapter is off
| void onGattConnectionStateException(BleGattException disconnectedGattException) { | ||
| disconnectionErrorRelay.call(disconnectedGattException); | ||
| @Override | ||
| public Observable<BleException> asExactObservable() { |
There was a problem hiding this comment.
What does it mean 'asExactObservable'? :) 😃 Could the method say something about the behavior?
| private final Future<?> runnableFuture; | ||
| private volatile boolean shouldRun = true; | ||
| private volatile BleDisconnectedException bleDisconnectedException = null; | ||
| private volatile BleException disconnectionException = null; |
There was a problem hiding this comment.
Effectively volatile is not required here because of synchronization. Having synchronized access guarantees that the other thread will read the value after the previous has written it.
uKL
approved these changes
Oct 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As long as the user is interested in the connection the
ConnectionOperationQueuewill check theDisconnectionRouterOutputfor exceptions that cause disconnection. If this exception is emitted theConnectionOperationQueueterminates itself with the emitted error. If the user unsubscribes from theRxBleDevice.establishConnection()then theConnectionOperationQueueterminates itself with theBleDisconnectedExceptionas it was before this change. Fixes #297