Added support for PendingIntent based scans in Android O+. This allow… #401

uKL · 2018-03-20T10:21:08Z

…s scanning without an active application, letting the system to wake up the process.

Fixes #369

dariuszseweryn

Finally had some time for looking into this

dariuszseweryn · 2018-04-09T10:00:49Z

rxandroidble/src/test/groovy/com/polidea/rxandroidble2/MockRxBleAdapterWrapper.groovy

@@ -69,6 +74,17 @@ class MockRxBleAdapterWrapper extends RxBleAdapterWrapper {

    }

+    @RequiresApi(Build.VERSION_CODES.O)
+    public int startLeScan(List<ScanFilter> scanFilters, ScanSettings scanSettings, PendingIntent callbackIntent) {
+    return 0


dariuszseweryn · 2018-04-09T10:08:08Z

rxandroidble/src/main/java/com/polidea/rxandroidble2/scan/BackgroundScanner.java

+     * @throws com.polidea.rxandroidble2.exceptions.BleScanException thrown if not possible to start the scan
+     */
+    @RequiresApi(Build.VERSION_CODES.O)
+    void scanBleDeviceInBackground(@NonNull PendingIntent callbackIntent, ScanSettings scanSettings, ScanFilter... scanFilters);


Thinking wether this should be Completable or not... On one hand this may only throw and is a synchronous call. On the other hand having a Completable would make it more consistent. Thoughts?

dariuszseweryn · 2018-04-09T10:09:19Z

rxandroidble/src/main/java/com/polidea/rxandroidble2/internal/scan/BackgroundScannerImpl.java

+    @Override
+    public void scanBleDeviceInBackground(@NonNull PendingIntent callbackIntent, ScanSettings scanSettings, ScanFilter... scanFilters) {
+        if (Build.VERSION.SDK_INT < Build.VERSION_CODES.O) {
+            Log.w(TAG, "PendingIntent based scanning is available for Android O and higher only.");


dariuszseweryn · 2018-04-09T10:09:59Z

rxandroidble/src/main/java/com/polidea/rxandroidble2/internal/scan/BackgroundScannerImpl.java

+        final android.bluetooth.le.ScanSettings nativeScanSettings = scanObjectsConverter.toNativeSettings(scanSettings);
+        final int scanStartResult = rxBleAdapterWrapper.startLeScan(nativeScanFilters, nativeScanSettings, callbackIntent);
+
+        if (scanStartResult != 0) {


scanStartResult != NO_ERROR?

dariuszseweryn · 2018-04-09T10:13:50Z

rxandroidble/src/main/java/com/polidea/rxandroidble2/scan/BackgroundScanner.java

+public interface BackgroundScanner {
+
+    /**
+     * Submits a scan request that will survive even if your process gets killed by the system. You can use this API to maintain a


survive => work — we should not use colloquialisms imo ;)

dariuszseweryn · 2018-04-09T10:14:15Z

rxandroidble/src/main/java/com/polidea/rxandroidble2/scan/BackgroundScanner.java

+
+    /**
+     * Submits a scan request that will survive even if your process gets killed by the system. You can use this API to maintain a
+     * background scan without a need to keep your application foreground and active. The system will manage the scan for you wand


wand => and

dariuszseweryn · 2018-04-09T10:17:25Z

...roidble/src/test/groovy/com/polidea/rxandroidble2/internal/scan/BackgroundScannerTest.groovy

+import static com.polidea.rxandroidble2.scan.ScanCallbackType.CALLBACK_TYPE_ALL_MATCHES
+
+@Config(manifest = Config.NONE)
+class BackgroundScannerTest extends RoboSpecification {


Shouldn't we also add tests for RxBleClient to call the BackgroundScanner?

The only thing it does it that it returns an instance that was injected through a constructor. No other interactions. I think it's not worth testing.

dariuszseweryn · 2018-04-09T10:18:26Z

sample/src/main/java/com/polidea/rxandroidble2/sample/example1_scanning/ScanActivity.java

@@ -59,7 +65,7 @@ public void onScanToggleClick() {
                            .setCallbackType(ScanSettings.CALLBACK_TYPE_ALL_MATCHES)
                            .build(),
                    new ScanFilter.Builder()
-                            .setDeviceAddress("B4:99:4C:34:DC:8B")
+                            .setDeviceAddress("5C:31:3E:BF:F7:34")
                            // add custom filters if needed


afaik there is need to put at least one filters—this could be mentioned here and in the docs

I'm gonna revert this change anyway. This is not relevant to a change we're introducing.

dariuszseweryn · 2018-04-09T10:19:18Z

...a/com/polidea/rxandroidble2/sample/example1a_background_scanning/BackgroundScanActivity.java

+                            .build(),
+                    new ScanFilter.Builder()
+                            .setDeviceAddress("5C:31:3E:BF:F7:34")
+                            // add custom filters if needed


maybe add a spinner for filtering with HRM service/weight scales/dunno other?

This may be a good idea if we'll be introducing a new example dedicated to filters.

…s scanning without an active application, letting the system to wake up the process. Fixes #369

uKL · 2018-06-04T12:36:07Z

Discussed changes were applied.

dariuszseweryn · 2018-06-04T12:37:53Z

CHANGELOG.md

@@ -1,5 +1,8 @@
 Change Log
 ==========
+Version 1.7.0


Version 1.7.0-SNAPSHOT ;) + we should make appropriate changes in gradle.properties

dariuszseweryn

Still I see Log references in the code (should be RxBleLog)

- Replaced Robospock with Electricspock. Robospock is not maintained and does not support new APIs ;(

dariuszseweryn

Two minor changes and we are ready to go 🚀

dariuszseweryn · 2018-06-07T11:01:33Z

mockrxandroidble/build.gradle

@@ -32,7 +32,10 @@ dependencies {
    testImplementation rootProject.ext.libs.junit
    testImplementation rootProject.ext.libs.groovy
    testImplementation rootProject.ext.libs.spock
-    testImplementation rootProject.ext.libs.robospock
+    testImplementation(rootProject.ext.libs.robolectric)
+    testImplementation (rootProject.ext.libs.electricspock){


Can we have consistent spaces?

dariuszseweryn · 2018-06-07T11:02:42Z

dependencies.gradle

@@ -13,11 +13,13 @@ ext {
            rxandroid          : 'io.reactivex.rxjava2:rxandroid:2.0.2',
            rxrelay            : 'com.jakewharton.rxrelay2:rxrelay:2.0.0',
            junit              : 'junit:junit:4.12',
-            groovy             : 'org.codehaus.groovy:groovy:2.4.12:grooid',
+            groovy             : 'org.codehaus.groovy:groovy:2.4.13',
            spock              : ['org.spockframework:spock-core:1.1-groovy-2.4',
                                  'cglib:cglib-nodep:3.2.6',
                                  'org.objenesis:objenesis:2.6'],
            robospock          : 'org.robospock:robospock:1.0.1',


No longer needed I suppose

dariuszseweryn

💯

uKL added the enhancement label Mar 20, 2018

uKL requested a review from dariuszseweryn March 20, 2018 10:21

uKL self-assigned this Mar 26, 2018

dariuszseweryn reviewed Apr 9, 2018

View reviewed changes

uKL added 2 commits June 4, 2018 14:23

Added support for PendingIntent based scans in Android O+. This allow…

41679e5

…s scanning without an active application, letting the system to wake up the process. Fixes #369

Review changes.

220e2c5

uKL force-pushed the feature/pending_intent_scan branch from 25b6b6f to 220e2c5 Compare June 4, 2018 12:34

dariuszseweryn reviewed Jun 4, 2018

View reviewed changes

dariuszseweryn approved these changes Jun 4, 2018

View reviewed changes

dariuszseweryn requested changes Jun 4, 2018

View reviewed changes

- Replaced Log.* with RxBleLog.*

24ea6cc

- Replaced Robospock with Electricspock. Robospock is not maintained and does not support new APIs ;(

dariuszseweryn requested changes Jun 7, 2018

View reviewed changes

Review changes

fdc8416

dariuszseweryn approved these changes Jun 7, 2018

View reviewed changes

uKL merged commit 28a2f97 into master Jun 7, 2018

uKL deleted the feature/pending_intent_scan branch June 7, 2018 11:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for PendingIntent based scans in Android O+. This allow… #401

Added support for PendingIntent based scans in Android O+. This allow… #401

uKL commented Mar 20, 2018

dariuszseweryn left a comment

dariuszseweryn Apr 9, 2018

dariuszseweryn Apr 9, 2018

dariuszseweryn Apr 9, 2018

dariuszseweryn Apr 9, 2018

dariuszseweryn Apr 9, 2018

dariuszseweryn Apr 9, 2018

dariuszseweryn Apr 9, 2018

uKL Jun 4, 2018

dariuszseweryn Apr 9, 2018

uKL Jun 4, 2018

dariuszseweryn Apr 9, 2018

uKL Jun 4, 2018

uKL commented Jun 4, 2018

dariuszseweryn Jun 4, 2018

dariuszseweryn left a comment

dariuszseweryn left a comment

dariuszseweryn Jun 7, 2018

uKL Jun 7, 2018

dariuszseweryn Jun 7, 2018

dariuszseweryn left a comment

Added support for PendingIntent based scans in Android O+. This allow… #401

Added support for PendingIntent based scans in Android O+. This allow… #401

Conversation

uKL commented Mar 20, 2018

dariuszseweryn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

uKL commented Jun 4, 2018

Choose a reason for hiding this comment

dariuszseweryn left a comment

Choose a reason for hiding this comment

dariuszseweryn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dariuszseweryn left a comment

Choose a reason for hiding this comment