Added GATT status code to a BleDisconnectException #405
Conversation
| /** | ||
| * Set when the state is not available, for example when the adapter has been switched off. | ||
| */ | ||
| public static final int UNKNOWN_STATE = -1; |
There was a problem hiding this comment.
Shouldn't it be status? And maybe STATUS_UNAVAILABLE?
| } | ||
|
|
||
| public BleDisconnectedException(Throwable throwable, @NonNull String bluetoothDeviceAddress) { | ||
| super(createMessage(bluetoothDeviceAddress), throwable); | ||
| public BleDisconnectedException(Throwable throwable, @NonNull String bluetoothDeviceAddress, int state) { |
There was a problem hiding this comment.
status
Plus this changes the public API :/
There was a problem hiding this comment.
Yes, should be status. Do you think that we should keep exception constructors as a part of the public API? If so, I can create a new one and deprecate the old one.
There was a problem hiding this comment.
We could deprecate the current constructors and add a LIBRARY_GROUP annotation to the new one
| } | ||
|
|
||
| public BleDisconnectedException(@NonNull String bluetoothDeviceAddress) { | ||
| super(createMessage(bluetoothDeviceAddress)); | ||
| public BleDisconnectedException(@NonNull String bluetoothDeviceAddress, int state) { |
| } | ||
|
|
||
| private static String createMessage(@Nullable String bluetoothDeviceAddress) { | ||
| return "Disconnected from " + bluetoothDeviceAddress; | ||
| private static String createMessage(@Nullable String bluetoothDeviceAddress, int state) { |
|
Any news here? In our project it really helped us to tackle some requirements. |
uKL
force-pushed
the
feature/282_added_status_to_exception
branch
from
6d3dfb9 to
3ae9ce3
Compare
|
@dariuszseweryn I applied the required changes. Could you have a look? |
|
|
||
| @Deprecated | ||
| public BleDisconnectedException() { |
There was a problem hiding this comment.
I know it is probably deprecated long enough but it is still a breaking API change
uKL
force-pushed
the
feature/282_added_status_to_exception
branch
from
a2e1368 to
6b4dbea
Compare
- Added GATT status to description mapping Fixes #282
uKL
force-pushed
the
feature/282_added_status_to_exception
branch
from
6b4dbea to
592dd19
Compare
|
|
||
| public static BleDisconnectedException adapterDisabled(String macAddress) { |
There was a problem hiding this comment.
This could be on the top level — not a nested class. Better sustainability I suppose.
Fixes #282