Scan record parser #711
Merged
Scan record parser #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dariuszseweryn
requested changes
Aug 20, 2020
...droidble/src/main/java/com/polidea/rxandroidble2/helpers/AdvertisedServiceUUIDExtractor.java
Outdated
Show resolved
Hide resolved
rxandroidble/src/main/java/com/polidea/rxandroidble2/internal/util/ScanRecordParser.java
Show resolved
Hide resolved
|
No problem I can restore these APIs as deprecated |
# Conflicts: # mockrxandroidble/src/main/java/com/polidea/rxandroidble2/mockrxandroidble/RxBleConnectionMock.java
|
I have restored the classes, but they are no longer used internally. I replaced the implementation of the functions with calls to the new |
# Conflicts: # mockrxandroidble/src/main/java/com/polidea/rxandroidble2/mockrxandroidble/RxBleConnectionMock.java
...droidble/src/main/java/com/polidea/rxandroidble2/helpers/AdvertisedServiceUUIDExtractor.java
Outdated
Show resolved
Hide resolved
rxandroidble/src/main/java/com/polidea/rxandroidble2/internal/util/UUIDUtil.java
Outdated
Show resolved
Hide resolved
rxandroidble/src/main/java/com/polidea/rxandroidble2/scan/ScanRecord.java
Outdated
Show resolved
Hide resolved
rxandroidble/src/test/groovy/com/polidea/rxandroidble2/internal/util/UUIDUtilTest.groovy
Outdated
Show resolved
Hide resolved
…Reverted suggesting users to use internal class (this is a fallout of suggesting users quite a long time ago on Stackoverflow to use UUIDUtil directly — will be fixed in 2.0.0).
|
I think you fixed all the issues you identified with this so I think it's good to merge. |
|
I have been a bit relieved from my other responsibilities recently so I plan to re-review and continue with this one soon. |
# Conflicts: # mockrxandroidble/src/main/java/com/polidea/rxandroidble2/mockrxandroidble/RxBleScanRecordMock.java
dariuszseweryn
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #709, this pull request removes UUIDUtil completely and replaces it with
ScanRecordParser, a new internal class.