Fix cache cleaning and add proper cache listing based on regexes. #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If specified only lists or purges cache entries that match the given regular expression. If not specified, lists all and purges all cache.
|
Nice work, I'll review that tomorrow. Thank you @kresike ✌️ |
darkweak
requested changes
May 31, 2022
Co-authored-by: darkweak <[email protected]>
|
Ok, I think I'm all done. @darkweak please review again when time permits. Thanks! |
|
Add yourself in the Credits section in the README. |
darkweak
approved these changes
May 31, 2022
|
Done! |
|
Thank you for this awesome work @kresike! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If specified only lists or purges cache entries that match the given
regular expression. If not specified, lists all and purges all cache.
If i've read correctly you are currently working on getting surrogate keys working properly.
I don't wish to step on your toes, it just seemed more logical to me to be able to list and purge cache contents selectively this way. If you think it's ok, please merge.