Skip to content

Add the discarded_futures lint; rev for publishing #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2025

Conversation

devoncarew
Copy link
Member

  • Aad the discarded_futures lint
  • rev for publishing

This is so we can dogfood discarded_futures on our own code to better eval the lint.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:dart_flutter_team_lints 3.5.0 ready to publish dart_flutter_team_lints-v3.5.0
package:firehose 1.0.0-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Mar 11, 2025
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
dart_flutter_team_lints None 3.4.0 3.5.0 3.4.0 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

@devoncarew devoncarew requested a review from kevmoo March 14, 2025 18:00
@devoncarew devoncarew merged commit b96e5d2 into main Mar 14, 2025
13 checks passed
@devoncarew devoncarew deleted the discarded_futures branch March 14, 2025 22:18
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Mar 18, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

core (https://github.com/dart-lang/core/compare/9f43210..61e6771):
  61e67710  2025-03-12  Moritz  Check for mandatory when using option (dart-lang/core#871)
  77d33c83  2025-03-04  Devon Carew  Update publish.yaml (dart-lang/core#870)
  db610bb5  2025-02-28  Erik Ernst  Adjust the implements clause of IntX (dart-lang/core#866)
  22d8879f  2025-02-27  Devon Carew  [package:lints] fix the changelog (dart-lang/core#867)
  2f0325e9  2025-02-26  Devon Carew  Contribute a Gemini Code Assist config (dart-lang/core#865)

ecosystem (https://github.com/dart-lang/ecosystem/compare/a3cc42d..5b8e6b8):
  5b8e6b8  2025-03-17  Devon Carew  [dart_flutter_team_lints] remove 'discarded_futures'; prep for publishing (dart-lang/ecosystem#347)
  b96e5d2  2025-03-14  Devon Carew  Add the discarded_futures lint; rev for publishing (dart-lang/ecosystem#346)

http (https://github.com/dart-lang/http/compare/001665e..9129a96):
  9129a96  2025-03-13  Brian Quinlan  Prepare to release cupertino_http 2.1.0 (dart-lang/http#1727)
  91d8719  2025-03-13  Brian Quinlan  Upgrade to `package:objective_c` 7.0.0 (dart-lang/http#1726)

i18n (https://github.com/dart-lang/i18n/compare/b09c822..d9cce0b):
  d9cce0b  2025-03-13  Moritz  Grab new artifacts from version `intl4x-icu-v.0.11.2-artifacts` (dart-lang/i18n#957)

protobuf (https://github.com/dart-lang/protobuf/compare/7838e44..0bab78d):
  0bab78d  2025-03-14  Devon Carew  rename -dev pubspec versions to -wip (google/protobuf.dart#968)

tools (https://github.com/dart-lang/tools/compare/9c53358..62bc13b):
  62bc13bc  2025-03-17  Kevin Moore  [markdown, stream_transform] Fix deprecated usage of pkg:web (dart-lang/tools#2046)
  f1a5e7a2  2025-03-17  Devon Carew  [package:markdown] update package:web references in the example (dart-lang/tools#2039)
  a4ae1759  2025-03-17  Nate Bosch  [package_config] Update language version and reformat (dart-lang/tools#2040)
  a2af1447  2025-03-17  Nate Bosch  [package_config] Remove unnecessary casts to Uint8List (dart-lang/tools#2041)
  07ebd15d  2025-03-14  Devon Carew  [package:mime] generate a markdown table of the current mime mappings (dart-lang/tools#2038)
  920fdb64  2025-03-13  dependabot[bot]  Bump dart-lang/setup-dart from 1.7.0 to 1.7.1 in the github-actions group (dart-lang/tools#2022)
  b55643da  2025-03-13  David Iglesias  [html] Allow ampersands in attribute values. (dart-lang/tools#2036)

Change-Id: I2998ebecfdc7b1790a74a8ab2128895694658a5f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/416023
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:dart_flutter_team_lints type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants