Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sharding): support sum function #388

Merged
merged 6 commits into from
Nov 29, 2022

Conversation

wbtlb
Copy link
Contributor

@wbtlb wbtlb commented Nov 29, 2022

What is changed and how it works?

What's Changed:

  • support sum function

@wbtlb wbtlb added app:pisa-proxy Pisa-Proxy related changes in:sharding Sharding related changes labels Nov 29, 2022
@wbtlb wbtlb added this to the v0.3.2 milestone Nov 29, 2022
@wbtlb wbtlb requested a review from xuanyuan300 November 29, 2022 10:51
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #388 (eae09b7) into master (df61eb4) will increase coverage by 6.38%.
The diff coverage is 82.17%.

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
+ Coverage   66.97%   73.36%   +6.38%     
==========================================
  Files           7        6       -1     
  Lines         427      732     +305     
==========================================
+ Hits          286      537     +251     
- Misses        133      184      +51     
- Partials        8       11       +3     
Flag Coverage Δ
unittests 73.36% <82.17%> (+6.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pisa-controller/pkg/proxy/server.go 20.00% <0.00%> (-2.23%) ⬇️
pisa-controller/pkg/webhook/server.go 26.66% <0.00%> (ø)
pisa-controller/pkg/proxy/http.go 51.35% <44.11%> (-6.55%) ⬇️
pisa-controller/pkg/webhook/injection.go 59.02% <82.56%> (+20.08%) ⬆️
pisa-controller/pkg/proxy/builder.go 90.97% <93.25%> (-0.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wbtlb wbtlb changed the title feat(sharding): support sum feat(sharding): support sum function Nov 29, 2022
wangbo added 2 commits November 29, 2022 11:00
@xuanyuan300
Copy link
Contributor

Good job.

@xuanyuan300 xuanyuan300 merged commit 3640d84 into database-mesh:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:pisa-proxy Pisa-Proxy related changes in:sharding Sharding related changes size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants