feat(footer): updated the signal url #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
views/shared/_dc_footer.ejs
Outdated
| @@ -3,7 +3,7 @@ | |||
| <span class="dc-footer--text"> | |||
| Put your R skills to the test | |||
| </span> | |||
| <a class="dc-footer--link btn btn-primary" href="https://www.datacamp.com/signal">Start Now</a> | |||
| <a class="dc-footer--link btn btn-primary" href="https://assessment.datacamp.com/r-programming">Start Now</a> | |||
There was a problem hiding this comment.
Would you want some more snowplow tracking out of the box? Could be nice to add a specific additional class name like ds-snowplow-btn-rdocs-signal or so
There was a problem hiding this comment.
Good idea, also added a few utm_* query params, I believe snowplow should pick these up too right?
There was a problem hiding this comment.
Yes! utm parameters are picked up too and have a ton of flexibility!
thomascorthouts
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the CTA in the footer to point straight to the r-programming assessment. We allow anonymous assessments now that allow users to take the assessment and in the end, require a registration/login to view their score.
Put this PR in draft for the time being while we figure out an issue with anonymous assessments.