Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add legend toggle on click for controlled subplots #770

Merged
merged 6 commits into from
Mar 28, 2025

Conversation

dv-usama-ansari
Copy link
Contributor

Closes N/A

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified @thinkh
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • Added legend click behavior for controlled subplots

Screenshots

2025-03-28.12-05-36.mp4

Additional notes for the reviewer(s)

  • Shall I add the legend click to faceted and scatter plot matrix as well?
  • This implementation might not be as straight forward

@dv-usama-ansari dv-usama-ansari requested a review from a team as a code owner March 28, 2025 11:07
@dv-usama-ansari dv-usama-ansari requested a review from thinkh March 28, 2025 11:07
@thinkh
Copy link
Member

thinkh commented Mar 28, 2025

@dv-usama-ansari Thanks for the update.

Shall I add the legend click to faceted and scatter plot matrix as well?

Yes, please do so because the customer actually uses the facets mode.

@dv-usama-ansari
Copy link
Contributor Author

With show all hide all buttons

2025-03-28.13-02-20.mp4

@thinkh
Copy link
Member

thinkh commented Mar 28, 2025

Thanks for the additional filter option. It works as expected for the facet mode.

scatterplot-filter-legend.webm

However, it does not work for the matrix mode.

image

I'd expect to see only the gray unknown points in this screenshot.

Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this because it works for the facet mode and that's what we need for the demo. Please fix the scatter plot matrix in the follow-up issue #771. Thanks.

@thinkh thinkh merged commit 755a68b into develop Mar 28, 2025
8 checks passed
@thinkh thinkh added the type: bug Something isn't working label Mar 28, 2025
@github-actions github-actions bot mentioned this pull request Mar 28, 2025
thinkh added a commit that referenced this pull request Mar 28, 2025
## What's Changed
* fix: add legend toggle on click for controlled subplots by
@dv-usama-ansari in #770


**Full Changelog**:
v17.3.0...v17.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants