Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logging #62

Merged
merged 32 commits into from
Oct 14, 2021
Merged

add logging #62

merged 32 commits into from
Oct 14, 2021

Conversation

dayyass
Copy link
Owner

@dayyass dayyass commented Oct 14, 2021

Closes #25

@dayyass dayyass added the enhancement New feature or request label Oct 14, 2021
@dayyass dayyass self-assigned this Oct 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021

Codecov Report

Merging #62 (89247f1) into develop (e1c552a) will increase coverage by 9.70%.
The diff coverage is 97.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #62      +/-   ##
===========================================
+ Coverage    87.82%   97.53%   +9.70%     
===========================================
  Files           27       31       +4     
  Lines          854      891      +37     
  Branches        73       72       -1     
===========================================
+ Hits           750      869     +119     
+ Misses          90       17      -73     
+ Partials        14        5       -9     
Flag Coverage Δ
unittests 97.53% <97.11%> (+9.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pytorch_ner/nn_modules/embedding.py 82.27% <ø> (ø)
pytorch_ner/utils.py 95.45% <ø> (+39.45%) ⬆️
pytorch_ner/logger.py 86.36% <86.36%> (ø)
pytorch_ner/__init__.py 100.00% <100.00%> (ø)
pytorch_ner/config.py 100.00% <100.00%> (ø)
pytorch_ner/dataset.py 100.00% <100.00%> (ø)
pytorch_ner/main.py 100.00% <100.00%> (ø)
pytorch_ner/metrics.py 100.00% <100.00%> (ø)
pytorch_ner/save.py 100.00% <100.00%> (+8.69%) ⬆️
pytorch_ner/train.py 100.00% <100.00%> (+24.35%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c552a...89247f1. Read the comment docs.

@dayyass dayyass merged commit 9eb7873 into develop Oct 14, 2021
@dayyass dayyass deleted the add_logging branch October 14, 2021 20:21
@dayyass dayyass mentioned this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants