Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json and jsonb types #6

Closed
wants to merge 1 commit into from
Closed

Add json and jsonb types #6

wants to merge 1 commit into from

Conversation

otiai10
Copy link

@otiai10 otiai10 commented Jan 23, 2019

This pull request is a proposal

It's helpful that users can select json and jsonb types.

@commitlint-wzrdtales
Copy link

There were the following issues with this Pull Request

  • Commit: 0770708
    • ✖ message may not be empty
      , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@commitlint-wzrdtales
Copy link

There were the following issues with this Pull Request

  • Commit: 6033248
    • ✖ message may not be empty
      , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@otiai10
Copy link
Author

otiai10 commented Feb 19, 2019

ping @wzrdtales

@viktor-ku
Copy link

@otiai10 Thank you very much, seems very useful!
@wzrdtales Can we have this merged please?

@wzrdtales
Copy link
Member

No, sry for the late response though.

The shared project only contains shared things.

JSON and JSONB are far from being a common thing across databases. Therefor they are only to be defined at driver level. This has been done already for example in the cockroachdb driver

https://github.com/db-migrate/cockroachdb/blob/5d474b2f408de3fd47d11007a388758131ce99d2/index.js#L257

and in the pg driver

https://github.com/db-migrate/pg/blob/3cb99a703376bba201b4b30433bb7aeb535701c8/index.js#L75-L77

So please feel free to go ahead and add it to the concerned driver, which carries support for that types.

@wzrdtales wzrdtales closed this May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants