Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix superflous whitespaces #23

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Fix superflous whitespaces #23

merged 2 commits into from
Jan 7, 2025

Conversation

Till--H
Copy link
Collaborator

@Till--H Till--H commented Jan 2, 2025

There were whitespaces at the beginning of every transcription and in other (random) places. By trimming the segments, we get rid of these superflous spaces.

Fixes issue 21.

@Till--H Till--H requested a review from dbpprt January 2, 2025 07:59
There were whitespaces at the beginning of every transcription and in other (random) places. By trimming the segments, we get rid of these superflous spaces. Fixes issue 21.
@Till--H
Copy link
Collaborator Author

Till--H commented Jan 2, 2025

Continuing to using this: The whitespace is helpful when inserting a sentence, stopping the recording, then doing a new recoring. This may lead to a missing space after the fullstop.

Maybe conditionally add a trailing whitespace after the whole inserted text, IF it ends on any form of punctuation.

This allows 'chaining' recordings together, e.g., for breaking them up into sentences
@dbpprt dbpprt merged commit 9a09bf5 into main Jan 7, 2025
@dbpprt dbpprt deleted the fix/spaces branch January 7, 2025 08:03
@dbpprt
Copy link
Owner

dbpprt commented Jan 7, 2025

Looks good, thanks @Till--H

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants