Composite Pass-Through Properties + Rescale

[dahlbyk]

As proposed in #611 (comment):

• height and width updates should cascade to children (fix Composite Chart Not Rescaling Bar Width #611)
• margins updates should cascade to children (fix need to call margins before compose for child charts to inherit #1003)
• title updates should cascade to children if/when shareTitle(true) (fix .title not working on composite of line charts #554)
• rescale() should cascade to children (no specific issue that I can find, but it seems important?)
  • There might be a larger bug here - my test is failing because resizing() on the children never goes to false
• label and renderLabel updates should cascade to children (defer fix for 2.0.x: label() not working for composite charts. #1314)

Still in progress, but opening PR to check CI and get feedback. cc @gordonwoodhull

[dahlbyk]

There might be a larger bug here - my test is failing because resizing() on the children never goes to false

To fix this I've made coordinateGridMixin.resizing() a setter, too, so it can be overridden in compositeChart. Technically this is a change to the public API, but it's not currently documented.

[dahlbyk]

label and renderLabel updates should cascade to children

I don't have a specific need here, so I'm going to leave this change out of this PR. If someone else needs #1314 fixed, you'd likely follow a pattern similar to what's found here.

@gordonwoodhull any feedback?

[kum-deepak]

Many thanks for your work @dahlbyk, currently heavy work is going on branch 3.0. Will it be possible for you to rebase and target your PR onto 3.0?

[dahlbyk]

Will it be possible for you to rebase and target your PR onto 3.0?

Done. We'll see if tests still pass. 😀

I'll leave the 2.x version at da3c437...NewBoCo:composite-props-2.x in case anyone needs it.

[dahlbyk]

Revisiting this (a year later!) as I'm finally upgrading from my patched v2 to v3. I've refactored a bit and included a fix for title/shareTitle as well.

[gordonwoodhull]

Apologies for the long delay on this. I was reminded of this PR by a question on SO.

Nice, clean implementation and special thanks for including tests!

Released in 3.1.5 and will port to the es6 branch shortly.

Thanks @dahlbyk!!

[dahlbyk]

Rebased v3.1.5 commits here: 1438f80...cdc1cda