Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dc.logger enhacements #1411

Closed
wants to merge 1 commit into from
Closed

dc.logger enhacements #1411

wants to merge 1 commit into from

Conversation

kum-deepak
Copy link
Collaborator

  • new function dc.logger.warnOnce
  • update code structure to somewhat similar to rest of dc
  • add missing test cases for dc.logger.deprecate
  • add documentation for dc.logger

I am planning to use dc.logger.warnOnce for #1409

@kum-deepak
Changes:
3d426a4 
- new function `dc.logger.warnOnce`
- update code structure to somewhat similar to rest of dc
- add missing test cases for `dc.logger.deprecate`
- add documentation for `dc.logger`
@kum-deepak kum-deepak changed the title Changes: dc.logger enhacements Apr 16, 2018
@gordonwoodhull
Copy link
Contributor

Nice infrastructure upgrade!

@gordonwoodhull
Copy link
Contributor

Please ensure that the first line of your commit message summarizes it. (Here I simply changed it to "dc.logger upgrades".) This is standard git etiquette.

@kum-deepak
Copy link
Collaborator Author

Will do :)

@gordonwoodhull
Copy link
Contributor

Thanks @kum-deepak! Released in 3.0 alpha 9.

Leaving the rest and cutting the tag now.

@kum-deepak kum-deepak deleted the logger-changes branch April 28, 2018 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kum-deepak @gordonwoodhull