[Refactor] Remove all ctx in math_kernel_op #5934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohanchen
approved these changes
Feb 26, 2025
|
I hope the precommit bot problem is solved now for this PR😫 |
16 tasks
Fisherd99
pushed a commit
to Fisherd99/abacus-BSE
that referenced
this pull request
Mar 31, 2025
* Remove ctx in dot_real_op * Fix dot_complex_wrapper bug * Remove ctx in vector_div_constant_op * Remove ctx in scal_op * Remove ctx in vector_mul_vector_op * Remove ctx in vector_div_vector_op * Fix compile bug * Remove ctx in constantVector_addOrsub_constantVector * Remove ctx in axpy_op * Remove ctx in axpy_op * Remove ctx in gemm_op * Remove ctx in matrixTranspose_op * Remove ctx in matrixSetToAnother * Fix bot compilation error 1 * Fix bot compilation eror 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As ctx in function parameters are completely useless, it need to be removed.
This pull requests removed ctx parameters in math_kernel_op.