Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using dict.get methods to get machine.local_root #1287

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

dingzhaohan
Copy link
Contributor

If local_root isn't ./, dpgen will raise error and exit, it seems local_root must be './', so I try to get a default value if machine.json doesn't provided it.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e86d821) 47.79% compared to head (cf6ea45) 47.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #1287   +/-   ##
=======================================
  Coverage   47.79%   47.79%           
=======================================
  Files          82       82           
  Lines       14586    14586           
=======================================
  Hits         6972     6972           
  Misses       7614     7614           
Files Changed Coverage Δ
dpgen/dispatcher/Dispatcher.py 83.78% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm
Copy link
Contributor

The dispatcher module is not maintained any more. One is supposed to use https://github.com/deepmodeling/dpdispatcher.
@njzjz shall we remove dpgen/dpdispatcher?

@dingzhaohan
Copy link
Contributor Author

func make_submission(dpgen/dispatcher/Dispatcher.py) is called in dpgen/generator/run.py. In make_submission, it first checks local_root, then initialize dpdispatcher.

@njzjz njzjz changed the title Using list.get methods to get machine.local_root Using dict.get methods to get machine.local_root Jul 25, 2023
@njzjz
Copy link
Member

njzjz commented Jul 25, 2023

The dispatcher module is not maintained any more. One is supposed to use https://github.com/deepmodeling/dpdispatcher.

@njzjz shall we remove dpgen/dpdispatcher?

It now only contains a wrapper of dpdispatcher.

@wanghan-iapcm wanghan-iapcm merged commit 2a6fd09 into deepmodeling:devel Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants