breaking: use shlex.quote to quote shell commands
#1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinzhe Zeng <[email protected]>
njzjz
changed the title
njzjz
changed the title
shlex.quote to quote shell commands
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #1396 +/- ##
=======================================
Coverage 48.98% 48.98%
=======================================
Files 83 83
Lines 14795 14796 +1
=======================================
+ Hits 7247 7248 +1
Misses 7548 7548
☔ View full report in Codecov by Sentry. |
wanghan-iapcm
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single quotes (
') can be automatically escaped. One does not need to escape single quotes incommandmanually anymore.To those who have escaped single quotes in
commandmanually, this is a breaking change.