Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disableIdentityWidgetInjection option #33

Merged
merged 7 commits into from
Oct 29, 2022
Merged

Add disableIdentityWidgetInjection option #33

merged 7 commits into from
Oct 29, 2022

Conversation

Marocco2
Copy link
Contributor

@Marocco2 Marocco2 commented Oct 25, 2022

Check if it compiles nicely as I am not capable of checking it

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2022

🦋 Changeset detected

Latest commit: d05ec03

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro-netlify-cms Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@delucis delucis linked an issue Oct 25, 2022 that may be closed by this pull request
@Marocco2 Marocco2 marked this pull request as ready for review October 25, 2022 18:20
Copy link
Owner

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Marocco2! I’ve left a couple of notes for things that need fixing.

I’m curious: how are you planning to use this? Without the widget injection, is it still possible to log in?

@Marocco2
Copy link
Contributor Author

Thanks @Marocco2! I’ve left a couple of notes for things that need fixing.

I’m curious: how are you planning to use this? Without the widget injection, is it still possible to log in?

If I've understood correctly, Identity widget is useful for sign up members but for login I can rely on Netlify CMS login page. I'm using a invite-only system and I don't require anymore this widget.

I'll make those changes shortly, so I can try my theory

Marocco2 and others added 2 commits October 29, 2022 11:37
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
@Marocco2 Marocco2 requested a review from delucis October 29, 2022 09:39
Copy link
Owner

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I’m planning on trying to create a pre-release with this change so you can test. Will let you know how to do that in a second.

@delucis delucis changed the title Added disableIdentityWidgetInjection Add disableIdentityWidgetInjection option Oct 29, 2022
@delucis delucis merged commit d62b891 into delucis:latest Oct 29, 2022
@github-actions github-actions bot mentioned this pull request Oct 29, 2022
@delucis
Copy link
Owner

delucis commented Oct 29, 2022

OK, all went well! You should be able to try this out by installing the next tag:

npm i astro-netlify-cms@next

Would you mind reporting back and saying how you get on? If this works, I’ll release this as the main 0.3.2, and if not we can revert. Thanks!

@Marocco2
Copy link
Contributor Author

OK, all went well! You should be able to try this out by installing the next tag:

npm i astro-netlify-cms@next

Would you mind reporting back and saying how you get on? If this works, I’ll release this as the main 0.3.2, and if not we can revert. Thanks!

I can confirm that it works as intended. I can still login with my account without using the widget

@Marocco2 Marocco2 deleted the patch-1 branch October 29, 2022 13:58
@delucis
Copy link
Owner

delucis commented Oct 29, 2022

Fantastic! I’ll get this released as 0.3.2 then — thanks @Marocco2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is it posible to only load the identity-widget on the /admin route?
2 participants