-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add disableIdentityWidgetInjection
option
#33
Conversation
🦋 Changeset detectedLatest commit: d05ec03 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Added ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Marocco2! I’ve left a couple of notes for things that need fixing.
I’m curious: how are you planning to use this? Without the widget injection, is it still possible to log in?
If I've understood correctly, Identity widget is useful for sign up members but for login I can rely on Netlify CMS login page. I'm using a invite-only system and I don't require anymore this widget. I'll make those changes shortly, so I can try my theory |
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I’m planning on trying to create a pre-release with this change so you can test. Will let you know how to do that in a second.
disableIdentityWidgetInjection
disableIdentityWidgetInjection
option
OK, all went well! You should be able to try this out by installing the npm i astro-netlify-cms@next Would you mind reporting back and saying how you get on? If this works, I’ll release this as the main |
I can confirm that it works as intended. I can still login with my account without using the widget |
Fantastic! I’ll get this released as 0.3.2 then — thanks @Marocco2! |
Check if it compiles nicely as I am not capable of checking it