Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add astro react() integration gotcha to README #52

Closed
wants to merge 1 commit into from
Closed

Add astro react() integration gotcha to README #52

wants to merge 1 commit into from

Conversation

JasperDeLanghe
Copy link

As suggested in #51

@changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2022

⚠️ No Changeset found

Latest commit: 7936911

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@delucis
Copy link
Owner

delucis commented Dec 18, 2022

Thanks for this and #51! I’ve actually been wondering if it makes most sense not to automatically include react() when adding the integration. This behaviour dates back to an early experiment that was much more tied to React components, but I suspect it could now work with or without @astrojs/react. In that case it would be better to leave that choice to each project instead of forcing a specific version of @astrojs/react on them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants