Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new cops #1106

Merged
merged 7 commits into from
May 7, 2021
Merged

Fix new cops #1106

merged 7 commits into from
May 7, 2021

Conversation

denny
Copy link
Owner

@denny denny commented May 7, 2021

Merge recently-released rubocop gems and fix their new warnings.

@denny denny added dependencies Updates to dependencies (gems and node modules) ruby Involves Ruby code code quality Primarily about code quality metrics (rather than deeper refactoring) labels May 7, 2021
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #1106 (3bd7c9d) into main (740ba4d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1106   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          361       361           
  Lines         5209      5208    -1     
=========================================
- Hits          5209      5208    -1     
Impacted Files Coverage Δ
.../controllers/shiny_forms/admin/forms_controller.rb 100.00% <ø> (ø)
...app/models/concerns/shinycms/plugins_components.rb 100.00% <100.00%> (ø)
plugins/ShinyCMS/app/models/shinycms/plugin.rb 100.00% <100.00%> (ø)
...pp/public/models/concerns/shinycms/has_template.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 740ba4d...3bd7c9d. Read the comment docs.

@denny denny merged commit 4f90075 into main May 7, 2021
@denny denny deleted the fix/new-cops branch May 7, 2021 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Primarily about code quality metrics (rather than deeper refactoring) dependencies Updates to dependencies (gems and node modules) ruby Involves Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant