Skip to content

#4834 - fix wrong path when root options is set #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −3
Open

#4834 - fix wrong path when root options is set #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ef025a
bug-version: re pasted the same code
deshanm May 17, 2022
7791c3c
ts-version: converted file into typescript
deshanm May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/response.js → lib/response.ts
View file
Original file line number Diff line number Diff line change
@@ -590,9 +590,7 @@ res.download = function download (path, filename, options, callback) {
opts.headers = headers

// Resolve the full path for sendFile
var fullPath = !opts.root
? resolve(path)
: path
var fullPath = resolve(path);

// send file
return this.sendFile(fullPath, opts, done)