Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add devcontainer-features and devcontainer-templates from irfansofyana #508

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

irfansofyana
Copy link

@irfansofyana irfansofyana commented Jan 2, 2025

What type of PR is this?

  • Add a new dev container collection
  • Update to an existing dev container collection
  • Documentation/spec update
  • Other containers.dev site update (UX, layout, etc)

Related Issues

  • Related Issue #
  • Closes #

Description

Hi folks, I'm adding my devcontainer-features: https://github.com/irfansofyana/devcontainer-features currently it contains kafkacat/kcat CLI that I cannot found in other features hence I created it.

I also add https://github.com/irfansofyana/devcontainer-templates to add a few templates, currently it contains go-template (a template for go developer)

Collection checklist

If your PR contributes a new collection, please utilize this checklist:

  • Collection name
  • Maintainer name
  • Maintainer contact link (i.e. link to a GitHub repo, email)
  • Repository URL
  • OCI Reference
  • I acknowledge that this collection provides new functionality, distinct from the existing collections part of this index.

@irfansofyana irfansofyana requested a review from a team as a code owner January 2, 2025 06:56
@irfansofyana irfansofyana changed the title docs: add devcontainer-features from irfansofyana docs: add devcontainer-features and devcontainer-templates from irfansofyana Jan 9, 2025
@Kaniska244
Copy link

Kaniska244 commented Feb 20, 2025

Hi @irfansofyana ,

Thank you for the PR. The feature one looks fine. But the template one (https://github.com/irfansofyana/devcontainers-templates) seems like a private repo. I am unable to see it. Would you kindly check once.

With Regards,
Kaniska

@irfansofyana
Copy link
Author

Hi @irfansofyana ,

Thank you for the PR. The feature one looks fine. But the template one (https://github.com/irfansofyana/devcontainers-templates) seems like a private repo. I am unable to see it. Would you kindly check once.

With Regards, Kaniska

oopss my bad it's a typo, it should be https://github.com/irfansofyana/devcontainer-templates, will fix it

@irfansofyana
Copy link
Author

please review it again @Kaniska244

@Kaniska244
Copy link

Change approved. This can be merged.

eljog
eljog previously approved these changes Feb 24, 2025
Copy link
Member

@eljog eljog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR
Please resolve conflicts

@irfansofyana
Copy link
Author

Please re-review it again @eljog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants