-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add devcontainer-features and devcontainer-templates from irfansofyana #508
base: gh-pages
Are you sure you want to change the base?
Conversation
Hi @irfansofyana , Thank you for the PR. The feature one looks fine. But the template one (https://github.com/irfansofyana/devcontainers-templates) seems like a private repo. I am unable to see it. Would you kindly check once. With Regards, |
oopss my bad it's a typo, it should be https://github.com/irfansofyana/devcontainer-templates, will fix it |
please review it again @Kaniska244 |
Change approved. This can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR
Please resolve conflicts
e2e9c0f
to
8d1d6ea
Compare
Please re-review it again @eljog |
What type of PR is this?
Related Issues
Description
Hi folks, I'm adding my devcontainer-features: https://github.com/irfansofyana/devcontainer-features currently it contains kafkacat/kcat CLI that I cannot found in other features hence I created it.
I also add https://github.com/irfansofyana/devcontainer-templates to add a few templates, currently it contains go-template (a template for go developer)
Collection checklist
If your PR contributes a new collection, please utilize this checklist: