Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dotnet-node #521

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

sebdanielsson
Copy link

What type of PR is this?

  • Add a new dev container collection
  • Update to an existing dev container collection
  • Documentation/spec update
  • Other containers.dev site update (UX, layout, etc)

Description

This PR adds a devcontainer for developing web apps using dotnet for the backend and Node.js for the frontend.

Collection checklist

If your PR contributes a new collection, please utilize this checklist:

  • Collection name
  • Maintainer name
  • Maintainer contact link (i.e. link to a GitHub repo, email)
  • Repository URL
  • OCI Reference
  • I acknowledge that this collection provides new functionality, distinct from the existing collections part of this index.

@sebdanielsson sebdanielsson requested a review from a team as a code owner February 3, 2025 16:44
@Kaniska244
Copy link

Hi @sebdanielsson ,

Thanks for the PR. Would you kindly modify the main Readme file (https://github.com/sebdanielsson/devcontainers/blob/main/README.md) of the repo with relevant details.

With Regards,
Kaniska

@sebdanielsson
Copy link
Author

Hi @sebdanielsson ,

Thanks for the PR. Would you kindly modify the main Readme file (https://github.com/sebdanielsson/devcontainers/blob/main/README.md) of the repo with relevant details.

With Regards, Kaniska

Thanks for the review! Should be fixed now👍

Sebastian

@Kaniska244
Copy link

Change approved. This can be merged.

ddoyle2017
ddoyle2017 previously approved these changes Feb 24, 2025
Copy link

@ddoyle2017 ddoyle2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! After the merge conflicts are fixed we can get this added in ⚡

@sebdanielsson
Copy link
Author

Just rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants