-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate dev workspace & odo validations #151
Comments
Maybe a first step here would be to gather in a document all the Devfile Specification validation rules that are not enforced by the Json schema:
Until now those rules are mainly described in the various initial (often already-closed) GH issues where we discussed the corresponding Devfile 2.0 feature. As soon as we have those Devfile Spec rules formally listed in a document, we would be able to implement them |
One problem I have noticed is with the protocol setting for endpoints, for example components.container.endpoints.protocol . By the spec the protocol value should be one of http, https, ws, wss, or tcp. However the schema does not appear to invalidate a setting which is not one of these values, unlike it does for for other one of properties, for example components.container.exposure. |
It has been agreed to:
|
See #227 |
Following the Devfile discussion, it was decided that the devfile validation would reside in devfile/api since the schema and go structs reside in devfile/api.
This issue tracks the work where we need to consolidate the validations for devfile present in dev workspace and odo repository.
The tools' specific validations will remain in their respective repository and only the validations wrt to the devfile spec will be moved to devfile/api.
The text was updated successfully, but these errors were encountered: