Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint protocol and secure updates #227

Closed
mmulholla opened this issue Nov 19, 2020 · 2 comments
Closed

Endpoint protocol and secure updates #227

mmulholla opened this issue Nov 19, 2020 · 2 comments
Assignees
Labels
area/api Enhancement or issue related to the api/devfile specification

Comments

@mmulholla
Copy link
Contributor

mmulholla commented Nov 19, 2020

  1. Currently the endpoint protocol is limited to "http", "ws", "tcp", "ws". This should be expanded to include "https" and "wss"

  2. The description for the secure flag should be updated to make it clear that when it is set to true the protocol should be set to either https or wss.

Note also that parser documentation must make it clear that when the protocl is set, for example, to http, and the secure attribute is set to true it is the responsibilty of the consumer of the parser to convert http to https.

This was discussed in the dev file cabal on Nov 19th: https://docs.google.com/document/d/1Zn6D1gNu1gDidtillni0hNAeU5pscfqwhx4mv3MmmwY

@mmulholla mmulholla self-assigned this Nov 20, 2020
@mmulholla
Copy link
Contributor Author

I created a branch with some changes. You can see them here:

master...mmulholla:protocolUpdates

Would appreciate feedback before I create a pull request. Also I am not sure if other changes are needed.

@elsony elsony added the area/api Enhancement or issue related to the api/devfile specification label Nov 23, 2020
@mmulholla
Copy link
Contributor Author

This is now complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Enhancement or issue related to the api/devfile specification
Projects
None yet
Development

No branches or pull requests

2 participants