Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial Kubernetes object generation piece to unblock openshift/console #184

Closed
yangcao77 opened this issue Oct 19, 2020 · 2 comments · Fixed by devfile/library#44
Closed
Assignees
Labels
area/library Common devfile library for interacting with devfiles

Comments

@yangcao77
Copy link
Contributor

Currently openshift/console is looking for common library from devfile/parser to generate a few Kubernetes objects

The issue is to

  1. Set up the initial struct of Kubernetes object generation in devfile/parser repo
  2. Create the 5 functions required by https://github.com/reginapizza/console/blob/addDevfile/pkg/server/devfile-handler.go#L34, to unblock their work

This issue does not include all kubernetes object generation work, which will be tracked by #181

@yangcao77 yangcao77 added the area/library Common devfile library for interacting with devfiles label Oct 19, 2020
@elsony
Copy link
Contributor

elsony commented Oct 30, 2020

@andrewballantyne @christianvogt You can use this item to track the devfile services common library work that the dev console needs for the devfile support.

@yangcao77
Copy link
Contributor Author

We are currently working on refactoring the generator code in odo, which contains functions dev console would need.
This is the PR to track, and it's currently under review: redhat-developer/odo#4134
Feel free to put PR review and suggestion in comments in the above PR.

After that PR got merged, we will simply copy over the generator pkg to devfile/library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/library Common devfile library for interacting with devfiles
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants