Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devfile parser library should generate Kube objects #181

Closed
maysunfaisal opened this issue Oct 15, 2020 · 4 comments
Closed

Devfile parser library should generate Kube objects #181

maysunfaisal opened this issue Oct 15, 2020 · 4 comments
Assignees
Labels
area/library Common devfile library for interacting with devfiles

Comments

@maysunfaisal
Copy link
Member

maysunfaisal commented Oct 15, 2020

The devfile/parser library should be able to generate basic Kubernetes objects from the devfile. The list of these functions and objects can be found documented at the design doc for the library and also the util funcs that can be found in the same doc.

Currently, Odo and Devworkspace operator repo generate their own Kube structs and objects, so there is a lot of redundant code and this issue will be solving that problem for all the consumers of the devfile/parser. For example, this google doc outlines the odo and devworkspace operator repo functions for these generator code.

The generated Kube objects are only going to be static objects ie; they would not need cluster communication.

Parent Issue: #144

@maysunfaisal maysunfaisal added the area/library Common devfile library for interacting with devfiles label Oct 15, 2020
@maysunfaisal
Copy link
Member Author

maysunfaisal commented Oct 19, 2020

I have outlined the work that needs to be done for this issue here in the document - https://docs.google.com/document/d/1ffLi37fM7LAjRK5SXAw-yVNwr9GchFYy_e_5VD-FOZc/edit#heading=h.v1ex47x85625

I have divided them into first pass and second pass; where first pass requires little to no refactoring of Odo code and is of higher priority compared to the second pass.

@yangcao77
Copy link
Contributor

The work in library repo has been done.
The only thing left is to port over the last piece of generator (GetInitContainer) to odo.

@yangcao77
Copy link
Contributor

PR created in Odo: redhat-developer/odo#4809

@yangcao77
Copy link
Contributor

This issue has been done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/library Common devfile library for interacting with devfiles
Projects
None yet
Development

No branches or pull requests

2 participants