Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default values on JSON schema #74

Closed
gorkem opened this issue Jun 8, 2020 · 1 comment · Fixed by #148
Closed

default values on JSON schema #74

gorkem opened this issue Jun 8, 2020 · 1 comment · Fixed by #148
Assignees
@davidfestal
Labels
area/api Enhancement or issue related to the api/devfile specification kind/enhancement New feature or request severity/P1 Issues that have a critical impact
Milestone
2.0

Comments

@gorkem
Copy link

gorkem commented Jun 8, 2020

devfile schema should specify the default values for properties that have them.
@l0rd l0rd added the kind/enhancement New feature or request label Jun 8, 2020
@l0rd l0rd added this to the 2.0.0 milestone Jun 11, 2020
@l0rd l0rd added the severity/P1 Issues that have a critical impact label Jun 11, 2020
@l0rd l0rd added the area/api Enhancement or issue related to the api/devfile specification label Jun 24, 2020
@davidfestal
Copy link
Collaborator

Initially I had specified default values as kube-builder annotations and they automatically went into the CRD OpenAPI schema.

But then there was an error, since it was a very recent feature and still not supported by the whole operator-sdk / OLM toolchain at this point, which is why I removed them.

But in the meantime we could quite easily accommodate this limitation in the script that generates CRDs and schemas from the Go source code.
I'll look into this after coming back from my PTO week (next week).

@davidfestal davidfestal self-assigned this Aug 13, 2020
davidfestal added a commit to davidfestal/api that referenced this issue Oct 5, 2020
@davidfestal
Add default management in the Json schema...
de21079 
- This should fix issue devfile#74
- This adds the `default` fields in the Json schema files,
and the `v1` CRDs, but *not* the `v1beta1` CRDs
since defaulting is not supported by it.

Signed-off-by: David Festal <[email protected]>
@davidfestal davidfestal mentioned this issue Oct 5, 2020
Merged
@davidfestal davidfestal linked a pull request Oct 5, 2020 that will close this issue
Add default fields in Json schemas and v1 CRDs #148
Merged
davidfestal added a commit to davidfestal/api that referenced this issue Oct 7, 2020
@davidfestal
Add default management in the Json schema...
794ec87 
- This should fix issue devfile#74
- This adds the `default` fields in the Json schema files,
and the `v1` CRDs, but *not* the `v1beta1` CRDs
since defaulting is not supported by it.

Signed-off-by: David Festal <[email protected]>
elsony pushed a commit that referenced this issue Oct 7, 2020
@davidfestal @elsony
Add default management in the Json schema...
5443b29 
- This should fix issue #74
- This adds the `default` fields in the Json schema files,
and the `v1` CRDs, but *not* the `v1beta1` CRDs
since defaulting is not supported by it.

Signed-off-by: David Festal <[email protected]>
@yhontyk yhontyk mentioned this issue Nov 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidfestal davidfestal

Labels
area/api Enhancement or issue related to the api/devfile specification kind/enhancement New feature or request severity/P1 Issues that have a critical impact
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Add default fields in Json schemas and v1 CRDs davidfestal/api
3 participants
@gorkem @l0rd @davidfestal