Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ginkgo version in registry operator #881

Closed
2 tasks done
kim-tsao opened this issue Jul 5, 2022 · 9 comments · Fixed by devfile/registry-operator#45
Closed
2 tasks done

Update Ginkgo version in registry operator #881

kim-tsao opened this issue Jul 5, 2022 · 9 comments · Fixed by devfile/registry-operator#45
Assignees
@michael-valdron
Labels
area/registry Devfile registry for stacks and infrastructure

Comments

@kim-tsao
Copy link
Contributor

kim-tsao commented Jul 5, 2022 •
edited by michael-valdron
Loading

Which area/kind this issue is related to?

/area registry

Issue Description

We are using a deprecated Ginkgo version in the registry operator repo. We should look into updating it using these instructions: https://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md#removed-custom-reporters

Acceptance Criteria

  • Replace ginkgo.RunSpecsWithDefaultAndCustomReporters with ginkgo.RunSpecs
  • Pass -ginkgo.fail-fast --ginkgo.junit-report=/tmp/artifacts/junit-devfileregistry-operator.xml as CLI arguments under test GnuMake task to replace parameters to the deprecated ginkgo.RunSpecsWithDefaultAndCustomReporters

Target Date: 08-31-2023
@kim-tsao kim-tsao mentioned this issue Apr 3, 2023
Closed
2 tasks
@michael-valdron
Copy link
Member

registry operator has updated this: devfile/registry-operator#45

@michael-valdron michael-valdron mentioned this issue Aug 24, 2023
Merged
3 tasks
@michael-valdron michael-valdron self-assigned this Aug 24, 2023
@michael-valdron michael-valdron moved this to Backlog in Devfile Project Aug 24, 2023
@michael-valdron
Copy link
Member

/area registry

@openshift-ci openshift-ci bot added the area/registry Devfile registry for stacks and infrastructure label Aug 24, 2023
@michael-valdron michael-valdron changed the title Update Ginkgo version Update Ginkgo version in registry operator Aug 24, 2023
@michael-valdron michael-valdron moved this from Backlog to In Review 👀 in Devfile Project Aug 28, 2023
@michael-valdron michael-valdron moved this from In Review 👀 to In Progress 🚧 in Devfile Project Aug 28, 2023
@michael-valdron michael-valdron moved this from In Progress 🚧 to In Review 👀 in Devfile Project Aug 28, 2023
@michael-valdron michael-valdron mentioned this issue Aug 28, 2023
Closed
3 tasks
@michael-valdron
Copy link
Member

Issue is ready for review: devfile/registry-operator#45

@michael-valdron michael-valdron mentioned this issue Aug 28, 2023
Merged
@michael-valdron
Copy link
Member

#1106 (comment)

@michael-valdron
Copy link
Member

unblocked: #1106 (comment)

@michael-valdron
Copy link
Member

#1106 (comment)

@michael-valdron
Copy link
Member

#1106 (comment)
#1106 (comment)

@michael-valdron
Copy link
Member

#1106 (comment)

@michael-valdron
Copy link
Member

#1106 (comment)

@michael-valdron michael-valdron moved this from In Review 👀 to Done ✅ in Devfile Project Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michael-valdron michael-valdron

Labels
area/registry Devfile registry for stacks and infrastructure
Projects
Devfile Project
Status: Done ✅
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates for operator sdk v1.28 michael-valdron/devfile-registry-operator
2 participants
@michael-valdron @kim-tsao