Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Registry Operator dependabot issues #1081

Closed
2 tasks
kim-tsao opened this issue Mar 27, 2023 · 3 comments
Closed
2 tasks

Fix Registry Operator dependabot issues #1081

kim-tsao opened this issue Mar 27, 2023 · 3 comments
Assignees
Labels
kind/user-story User story for new enhancement

Comments

@kim-tsao
Copy link
Contributor

/kind user-story

Which area this user story is related to?

/area registry-operator

User Story

As a devfile registry administrator I want to install the registry operator and ensure the build image is free of vulnerabilities

Acceptance Criteria

  • ....
  • ....
@openshift-ci openshift-ci bot added the kind/user-story User story for new enhancement label Mar 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 27, 2023

@kim-tsao: The label(s) area/registry-operator cannot be applied, because the repository doesn't have them.

In response to this:

/kind user-story

Which area this user story is related to?

/area registry-operator

User Story

As a devfile registry administrator I want to install the registry operator and ensure the build image is free of vulnerabilities

Acceptance Criteria

  • ....
  • ....

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kim-tsao kim-tsao self-assigned this Mar 27, 2023
@kim-tsao kim-tsao added kind/user-story User story for new enhancement and removed kind/user-story User story for new enhancement labels Mar 27, 2023
@kim-tsao
Copy link
Contributor Author

Updating the controller runtime removes the following package. Will need to find a replacement:

sigs.k8s.io/controller-runtime/pkg/envtest/printer: module sigs.k8s.io/controller-runtime@latest found (v0.14.5), but does not contain package sigs.k8s.io/controller-runtime/pkg/envtest/printer

@kim-tsao
Copy link
Contributor Author

kim-tsao commented Apr 3, 2023

If we bump up the controller runtime, we will be forced to update Gingko v2 which requires migration since we are currently on v1 which is deprecated. I tried to migrate according to the instructions but the tests did not seem to run at all (no console output was emitted and only the unit tests ran successfully)

We have an open issue to do this work and I think we will need to prioritize it soon: #881

In the meantime, I'll see if I can keep the controller runtime version at the current level in order to fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/user-story User story for new enhancement
Projects
None yet
Development

No branches or pull requests

1 participant