Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git and openssh in the tooling image #100

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

davidfestal
Copy link
Collaborator

@davidfestal davidfestal commented Jul 20, 2020

What does this PR do?

This PR adds git and openssh in the tooling image.
git is required to perform some of the Go commands under some conditions (especially the go test command)

What issues does this PR fix or reference?

This PR is related to other PR #98 which introduces GO tests and add a run tests devfile command.

Is your PR tested?

Yes, on che.penshift.io

`git` is required to perform some of the Go commands under some conditions (especially the `go test` command)
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment: PR clearly describes why git is needed but no info about the use case for openssh.

@davidfestal davidfestal merged commit 9c20295 into master Jul 20, 2020
@davidfestal davidfestal deleted the add-git-in-tooling-image branch July 20, 2020 11:28
@davidfestal
Copy link
Collaborator Author

Just one comment: PR clearly describes why git is needed but no info about the use case for openssh.

Afaict it's useful for git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants