add keyset length check #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephanie <[email protected]>
yangcao77
requested review from
amisevsk,
davidfestal and
sleshchenko
as code owners
Signed-off-by: Stephanie <[email protected]>
amisevsk
approved these changes
Dec 11, 2020
| @@ -116,6 +116,9 @@ func OverrideDevWorkspaceTemplateSpec(original *workspaces.DevWorkspaceTemplateS | |||
|
|
|||
| func ensureOnlyExistingElementsAreOverridden(spec *workspaces.DevWorkspaceTemplateSpecContent, overrides workspaces.Overrides) error { | |||
| return checkKeys(func(elementType string, keysSets []sets.String) []error { | |||
| if len(keysSets) <= 1 { | |||
There was a problem hiding this comment.
Totally optional nit
Suggested change
| if len(keysSets) <= 1 { | |
| if len(keysSets) < 2 { |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, yangcao77 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephanie [email protected]
What does this PR do?
should not assume the keyset length
add keyset length check before access
keyset[0]andkeyset[1]What issues does this PR fix or reference?
fixes #276
Is your PR tested? Consider putting some instruction how to test your changes
tested with parser unit test