Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more merging and overriding tests #308

Merged
merged 3 commits into from
Jan 21, 2021

Conversation

amisevsk
Copy link
Contributor

What does this PR do?

Adds a few tests for the merging/overriding package:

What issues does this PR fix or reference?

Fixes #295 and provides a regression test for #276

Is your PR tested? Consider putting some instruction how to test your changes

go test ./pkg/utils/...

Docs PR

Bugfix; no docs required.

Copy link
Collaborator

@davidfestal davidfestal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amisevsk, davidfestal
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amisevsk amisevsk force-pushed the merging-and-overriding-tests branch from a154e82 to 046bd7f Compare January 20, 2021 23:33
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@amisevsk amisevsk merged commit 198daa6 into devfile:master Jan 21, 2021
@amisevsk amisevsk deleted the merging-and-overriding-tests branch January 21, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Merging] passing in nil in MergeDevWorkspaceTemplateSpec causes panic
3 participants