Implement proposal #31 for better plugin mechanism and cleanup Json schema #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to define Spring boot example Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
.. and update the parent override mechanism to use a common strategic merge patch approach Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
... that are derived from the CRD Openapi schema And also upgrade the operator-sdk used for CRD generation to 0.17.0 Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
|
Open Developer Workspace: |
|
After confirmation from @l0rd, let me merge this PR and provide remaining changes in new PRs. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements in the proposal #31 that was agreed on,
especially the overriding mechanism for parent devfiles and plugins
based on strategic merge patch (a-la-kustomize).
This PR also enhances the build mechanism that derives JSON schemas from
the generated K8S CRD OpenApi schema. Especially it:
As part of this enhancement, this PR also upgrades the version of the
operator-sdkCLI tools used to generate the CRDs to0.17.0What issues does this PR fix or reference?
This PR implements issue #31
Is your PR tested? Consider putting some instruction how to test your changes
Yes