Enable test coverage + upload results in workflow #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim-tsao
requested review from
amisevsk,
davidfestal and
sleshchenko
as code owners
amisevsk
approved these changes
Jun 1, 2021
johnmcollier
approved these changes
Jun 1, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, johnmcollier, kim-tsao The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the ci.yml to enable test coverage for go tests and to upload the resultant html report file. Similar to the changes that were done for the library tests in devfile/library#91
What issues does this PR fix or reference?
#470
Is your PR tested? Consider putting some instruction how to test your changes
I could not test the yaml file but I copied and pasted the go test/tool commands and ran them manually. I'd have to check the workflow results of this PR to verify if the report artifact was uploaded.
Docs PR
Docs are N/A but README was updated