[wip] add RunOnDemand changes in devfile api. It is not ready to be merged.

[rajibmitra]

What does this PR do?:

This is the changes for RunOnDemand in container component.

Which issue(s) this PR fixes:

#852

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rajibmitra

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[amisevsk]

As discussed in the community call on June 20th, this is a breaking change and inverts the current default for container components. I don't think it's suitable to merge (with a default value of false) without moving to a new API version.

[rajibmitra]

Thanks @amisevsk, any idea when we are planning to move to new API version ?

[amisevsk]

The new API version in question would likely need to be v3.0.0, which is a very significant change that as far as I know isn't on the horizon yet.

If the default here was true, then it would be a compatible change and we could push it in the next v2.x.0 API version.

[rajibmitra]

@l0rd can we make default here true for the next release with v2.x.0 version ?

[yangcao77]

@rajibmitra
We need to rethink on the RunOnDemand design, as discussed in the community meeting. We are currently have two alternative proposals, and need more discussion upon that after we have detailed proposal & examples. #864 (comment)

The new API version in question would likely need to be v3.0.0, which is a very significant change that as far as I know isn't on the horizon yet.
If the default here was true, then it would be a compatible change and we could push it in the next v2.x.0 API version.

Regarding on when to bump up the version, #46 is the only issue we left for devfile 2.2. we should think of a backward compatible design for the next 2.x.0 version.

[rajibmitra]

thank you @yangcao77 for the clarification.

[l0rd]

@amisevsk I must admit that the name is confusing but runOnDemand: false means that the container gets started automatically, not on demand. That corresponds to current behavior. As you mention we don't want to change current behavior. This is also explained here.

But, as mentioned by @yangcao77, on the 20th of June Devfile Cabal, we have discussed some different syntax and @kadel is looking at the proposal but is currently on vacation so we need to be patient, and I don't think that there is any urgency.

@rajibmitra until we do not have an agreement on the syntax I would recommend you to:

• Set this PR as a draft and make it clear that it's not ready to be merged, the syntax will be changed
• Join the Cabal call on mondays, add topics if you have questions or want to discuss
• View at the recording of the 20th of June Devfile Cabal (@elsony may be able to share it if that's blocked)
• Get familiar with the DevWorkspace operator and implement the controller changes related to this PR

[kadel]

Just making sure that everyone is aware of this: The updated proposal is at #852 (comment)
THis was discussed in this weeks devfile community call.

[maysunfaisal]

Closing this PR as its been WIP for 2 years.