Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added section for devfile library #111

Merged
merged 4 commits into from
Dec 2, 2021
Merged

added section for devfile library #111

merged 4 commits into from
Dec 2, 2021

Conversation

jc-berger
Copy link
Contributor

@jc-berger jc-berger commented Nov 4, 2021 •
edited
Loading

Fixes devfile/api#157 ; devfile/api#144

See the Jira ticket: https://issues.redhat.com/browse/RHDEVDOCS-2667

I added a section and included new library docs. I took a lot of the content from this devfile library repo: https://github.com/devfile/library

@jc-berger jc-berger added the documentation Improvements or additions to documentation label Nov 4, 2021
@jc-berger jc-berger self-assigned this Nov 4, 2021
yangcao77
yangcao77 approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@yangcao77 yangcao77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc LGTM from a developer point of view.

@openshift-ci openshift-ci bot added the lgtm label Nov 15, 2021
rkratky
rkratky approved these changes Nov 30, 2021
View reviewed changes
Copy link

@rkratky rkratky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jc-berger, approving, but this section should be reformatted to take the comments out of the source code. Also, syntax highlighting should be used.

@openshift-ci
Copy link

openshift-ci bot commented Nov 30, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jc-berger, rkratky, yangcao77

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rkratky
Copy link

rkratky commented Nov 30, 2021

Actually, @jc-berger, what is the reasoning for putting this into the admin guide? I think it's for developers.

@jc-berger jc-berger mentioned this pull request Dec 1, 2021
Closed
@openshift-ci
Copy link

openshift-ci bot commented Dec 1, 2021

New changes are detected. LGTM label has been removed.

@jc-berger
Copy link
Contributor Author

@rkratky made a new issue and made a new commit, addressing your feedback, thanks!

@rkratky rkratky merged commit 4811803 into devfile:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfedh rolfedh rolfedh left review comments

@bburt-rh bburt-rh bburt-rh left review comments

@rkratky rkratky rkratky approved these changes

@yangcao77 yangcao77 yangcao77 approved these changes

Assignees

@rkratky rkratky

@yangcao77 yangcao77

@jc-berger jc-berger

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial common devfile library support
5 participants
@jc-berger @rkratky @rolfedh @yangcao77 @bburt-rh