Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate downloading of git resources #174

Merged
merged 3 commits into from
Jul 7, 2023

Conversation

maysunfaisal
Copy link
Member

@maysunfaisal maysunfaisal commented Jun 29, 2023

What does this PR do?:

Gates the logic for downloading git resources. Clients od devfile/library may be running behind a proxy, so we cannot invoke git operations as they may fail

Which issue(s) this PR fixes:

Fixes devfile/api#1176

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

Signed-off-by: Maysun J Faisal <[email protected]>
Signed-off-by: Maysun J Faisal <[email protected]>
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage: 81.25% and project coverage change: -0.02 ⚠️

Comparison is base (04a8b3f) 59.73% compared to head (cff5c26) 59.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
- Coverage   59.73%   59.72%   -0.02%     
==========================================
  Files          41       41              
  Lines        5119     5125       +6     
==========================================
+ Hits         3058     3061       +3     
- Misses       1866     1868       +2     
- Partials      195      196       +1     
Impacted Files Coverage Δ
pkg/devfile/parser/parse.go 60.70% <81.25%> (-0.10%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maysunfaisal maysunfaisal marked this pull request as ready for review June 30, 2023 20:39
@openshift-ci openshift-ci bot requested review from elsony and yangcao77 June 30, 2023 20:39
@maysunfaisal maysunfaisal requested a review from mike-hoang June 30, 2023 20:39
Copy link
Contributor

@mike-hoang mike-hoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Should we add a small update to the readme doc about the new parser arg too?

@openshift-ci
Copy link

openshift-ci bot commented Jul 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maysunfaisal, mike-hoang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Maysun J Faisal <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Jul 7, 2023
@maysunfaisal
Copy link
Member Author

@mike-hoang README has been updated

@mike-hoang
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 7, 2023
@maysunfaisal maysunfaisal merged commit 6c4a5b8 into devfile:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to gate downloading of git resources
2 participants