Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 2.0 and 2.1 schema #55

Merged
merged 4 commits into from
Feb 1, 2021

Conversation

yangcao77
Copy link
Collaborator

@yangcao77 yangcao77 commented Jan 27, 2021

What does this PR do?

The PR saves a copy of GA version of devfile 2.0 schema, and put latest devfile schema under 2.1.0 folder
This PR adds support for devfile 2.1, and pulls latest api pkg
modifies main.go to accept an arg which can be a http/https URL or a devfile path

What issues does this PR fix or reference?

Fixes devfile/api#326

Is your PR tested? Consider putting some instruction how to test your changes

pass the unit tests and api tests

Signed-off-by: Stephanie <[email protected]>
@yangcao77 yangcao77 force-pushed the 326-multi-version-support branch from f4b407c to ce44225 Compare January 27, 2021 18:49
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maysunfaisal, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maysunfaisal,yangcao77]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangcao77 yangcao77 merged commit ae471a9 into devfile:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

library should support both devfile 2.0 and 2.1
3 participants