validation consolidation

[yangcao77]

What does this PR do?

This PR integrates validation into devfile/libaray
also updates the api test to generate valid devfiles for tests

What issues does this PR fix or reference?

devfile/api#337

Is your PR tested? Consider putting some instruction how to test your changes

[mmulholla]

Notes on test updates. I had to rewire the tests for validations:

1. When testing an exec command a component container is also needed with the command id listed.
2. When testing component container with a volume the component volume must also exist.
3. When testing a composite command the commands listed must also exist.
4. Groups, each kind added to the devfile requires at least one and no more that one default.
5. The ports specified in endpoints must be unique between containers.

Apart from the obvious addition of logic for these I added, for example, commandAdded (called whenever a command is created) and commandUpadated (called whenever a command is updated). These methods keep the test and parser data updated for when they are written and actually simplifies other areas of the code. However this is key to supporting edits that affect, for example, both commands and components.

[yangcao77]

The command field under container component is unrelated to Commands defined in devfile.
command and args in container are actually the docker container entrypoints(in dockerfile)

This restriction should be removed

[mmulholla]

removed. Main change was when I created an exec command I called a function to add the command to the container - now the function just returns the name of a container without adding the command to it.

[yangcao77]

Are we going to test component with multiple endpoints in the future?
Just to note that, the port defined in endpoints has to be unique across components, but same container can have multiple endpoints sharing the same port.

So the restriction looks correct in the current test coverage, but are we looking to expend the coverage?

[mmulholla]

Test already includes multiple endpoints. Updated the test so that it will randomly use the same port when adding multiple endpoint to a given container.

[yangcao77]

perhaps create type of schema.Command, and pass in &command
can use a switch case here. depends on your preference

[mmulholla]

I kind of like it how it is but can look at it more. OK to defer to later?

[yangcao77]

minor suggestion:
I saw all the tests created are setting those values. can create a func newTestContent()

newTestContent(commandType, editContent) {
	testContent := TestContent{}
	testContent.CommandTypes = commandType
	testContent.EditContent = editContent
	testContent.FileName = utils.GetDevFileName()

        return testContent
}

[mmulholla]

The kicker here is that utils.GetDevFileName() creates a filename based on the calling function name so it needs to be in the test function. I could update it to walk the stack until it finds the Test_* function but would rather not in this pull request. Also I have though of similar in the past but just thought it would not save much.

[yangcao77]

Martim's test changes overall look good, just some minor suggestions.

[mmulholla]

@elsony are we good to merge now? Can you approve?

[elsony]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elsony, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [elsony,yangcao77]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment