update controller-gen

[kim-tsao]

Signed-off-by: Kim Tsao [email protected]

Please specify the area for this PR

What does does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #?
devfile/api#1013

In addition to the changes mentioned in this comment, I had to update the controller-manager and kube-rbac-proxy sccs in order to fix the warning on openshift:

Warning: would violate PodSecurity "restricted:v1.24": allowPrivilegeEscalation != false (container "kube-rbac-proxy" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (containers "kube-rbac-proxy", "manager" must set securityContext.capabilities.drop=["ALL"]), seccompProfile (pod or containers "kube-rbac-proxy", "manager" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")

PR acceptance criteria:

• Test Coverage
  • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
• Gosec scans
  • Fix all MEDIUM and higher findings and/or annotate a finding per gosec instructions: https://github.com/securego/gosec#annotating-code to address why a finding is not a security issue

Documentation

• Does the registry operator documentation need to updated with your changes?

How to test changes / Special notes to the reviewer:

[michael-valdron]

go mod tidy: go.mod file indicates go 1.18, but maximum supported version is 1.17 our integration tests need updating to support golang 1.18, we could cap it at 1.17 until this support is added.

[michael-valdron]

Aside from my suggestions there might be other changes needed to stay at golang 1.17.

[michael-valdron]

go mod tidy: go.mod file indicates go 1.18, but maximum supported version is 1.17 our integration tests need updating to support golang 1.18, we could cap it at 1.17 until this support is added.

/lgtm

I see your changes for testing support openshift/release#36276 you can disregard my review suggestions.

[kim-tsao]

/retest

[michael-valdron]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, michael-valdron

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kim-tsao]

/retest

[openshift-ci]

New changes are detected. LGTM label has been removed.

[kim-tsao]

/retest

[kim-tsao]

Also updated a couple of dependencies related to upgrading the operator-sdk: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.25.0/