Use an nginx proxy server in the metadata server #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
openshift-ci-robot
added
the
approved
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
4 tasks
GeekArthur
reviewed
Nov 18, 2020
GeekArthur
approved these changes
Nov 18, 2020
Signed-off-by: John Collier <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GeekArthur, johnmcollier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Collier [email protected]
What does does this PR do / why we need it:
Sets up a simple nginx reverse proxy on the metadata-server containe, allowing clients to connect to the OCI registry's v2 api (running on port 5000 in the same pod) to pull devfiles.
This PR also properly reformats the metadata-server container image to be used as a base image for the devfile stacks + index (see devfile/registry#1, and https://github.com/devfile/api/blob/master/docs/proposals/registry/devfile-packaging.md). As a result, this container no longer packages the index.json or devfile stacks and is no longer meant to be deployed directly, but rather be used as a base image for the devfile index image.
Which issue(s) this PR fixes:
devfile/api#190, only partially (see last bullet point)