Set OCI registry and index server images to use non-root numeric active users #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Valdron <[email protected]>
3 tasks
Codecov ReportBase: 43.92% // Head: 43.92% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
=======================================
Coverage 43.92% 43.92%
=======================================
Files 6 6
Lines 1020 1020
=======================================
Hits 448 448
Misses 530 530
Partials 42 42 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
johnmcollier
approved these changes
Dec 20, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnmcollier, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Valdron [email protected]
Please specify the area for this PR
oci-registry
index-server
What does does this PR do / why we need it:
Changes active users of the images
oci-registryanddevfile-index-baseto use uid1001and set group permissions to0. These changes fix container deployment errors in minikube when using therunAsNonRootsecurity context.Which issue(s) this PR fixes:
Fixes #?
part of devfile/api#747
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer: