SVG extraction failes on icons containing a comment at the top (f.e. bash-plain.svg)

[amacado]

EDIT: See #444 (comment) for explaination

There is a problem with displaying the plain version of the new bash icon. It shows up but not displaying the svg code below:
It works fine for the original version and also for the font versions. I wonder if this might be a result of the updated build process (removing color function or so? It's just a guess).

Interesting fact: When you open the svg in the browser it will show repeated:
https://raw.githubusercontent.com/devicons/devicon/master/icons/bash/bash-plain.svg

[Thomas-Boi]

Hmm that's strange. The Icomoon color removal only applies to the font. The original SVG is not affected in anyway.

[amacado]

This was just a guess on my side, it is probably another reason..

[EnisMulic]

@amacado I just checked and it looks like there was some extra svg elements in the original file I took, removing that seems to fix the issue
https://raw.githubusercontent.com/EnisMulic/devicon/fix/icon/bash/icons/bash/bash-plain.svg

[Thomas-Boi]

@EnisMulic I was wondering about that too. It seems that the plain version somehow has more content than the original.

Can you create a new PR that contain this fix please?

[amacado]

The error is still there. I will investigate further. Think it's related to the way we extract the svg to show the code.

[amacado]

Yep, the error is related to the way we extract the information from the svg. When there is a comment block at the beginning of the svg we fail in showing the correct code. Some examples:

I will rename the issue and setup a fix for this.

[Thomas-Boi]

Wow, that's an interesting bug. I have merge your fix into develop. Let's hope that this will be the last time we see this issue.

[amacado]

Fixed in https://github.com/devicons/devicon/releases/tag/v2.8.2