Skip to content

build(icomoon): fix missing eot file and add font metadata #2361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ReenigneArcher
Copy link

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

This PR fixes the issue of the missing .eot file when building the fonts.

The issue was that the Support IE 8 checkbox was unselected in the icomoon.json. I also added some metadata to the icomoon.json

image
image

This PR closes NONE

Notes

@ReenigneArcher ReenigneArcher changed the base branch from master to develop February 15, 2025 20:11
@ReenigneArcher ReenigneArcher changed the title Build/icomoon/fix missing eot file and add font metadata build(icomoon): fix missing eot file and add font metadata Feb 15, 2025
@ReenigneArcher
Copy link
Author

As an alternative to this, we could programmatically modify the icomoon.json before the import process begins. Let me know if that's preferred over this approach.

@Snailedlt
Copy link
Collaborator

Snailedlt commented Feb 17, 2025

@ReenigneArcher
I don't have any preferences. Choose the one that you think is best.
Basically make sure it's as stable as possible while keeping it easily maintainable :)

@ReenigneArcher
Copy link
Author

@Snailedlt sounds good. I am good with this PR as is. It's the easiest and fastest approach to getting the build working again.

I know it's not easy to review this one since the json is minified.

The process I took was simply:

  1. import the existing file to the icomoon app
  2. adjust the settings
  3. download the font
  4. extract the json file from the archive and rename it to icomoon.json

@Snailedlt
Copy link
Collaborator

@ReenigneArcher wouldn't this need to be done for every release then, since icomoon.json contains the font for each icon as well as the settings.

@ReenigneArcher
Copy link
Author

No, it shouldn't need to be. I think the icomoon app just changed some of their settings so the way it was imported would no longer generate the .eot. Enabling the IE 8 checkbox in the icomoon.json makes sure the .eot file is generated. I believe it will be imported properly on each build/release, and the settings will stay intact until they change something else.

@ReenigneArcher
Copy link
Author

What is needed to get this merged? Builds won't work until this is in.

@ReenigneArcher ReenigneArcher force-pushed the build/icomoon/fix-missing-eot-file-and-add-font-metadata branch from dcc06b8 to 668d08e Compare February 28, 2025 16:20
@canaleal
Copy link
Member

canaleal commented Mar 9, 2025

@ReenigneArcher All is good, just update this branch and it can be merged.
Great work as always.

@ReenigneArcher ReenigneArcher force-pushed the build/icomoon/fix-missing-eot-file-and-add-font-metadata branch from 668d08e to e4ee895 Compare March 9, 2025 23:54
@ReenigneArcher
Copy link
Author

@canaleal I rebased the branch. Thank you!

@canaleal canaleal merged commit 0eefcb2 into devicons:develop Mar 10, 2025
5 checks passed
@ReenigneArcher ReenigneArcher deleted the build/icomoon/fix-missing-eot-file-and-add-font-metadata branch March 10, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants