Skip to content

new icon: jamstack (original, original-wordmark, plain-wordmark) #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2021

Conversation

tupaschoal
Copy link
Contributor

Original:
svg_2
Original-wordmark:
jamstack-original-wordmark
Plain-wordmark
jamstack-plain-wordmark

I was a bit confused on whether I should define those as line or not (or at least alias them as line-... Let me know what you think

@Thomas-Boi
Copy link
Member

I think this is fine. An informal rule that I follow is if it's unclear, the priority is original > plain > line. This is because original and plain are more common than line => people are more likely to search up those versions.

@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection labels Jul 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons look great! Thank you for your work 😃

@Thomas-Boi Thomas-Boi merged commit 5f1f59b into devicons:develop Jul 4, 2021
@tupaschoal tupaschoal deleted the add-jamstack branch July 5, 2021 00:54
@amacado amacado mentioned this pull request Aug 14, 2021
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants