feat(crypto): CRP-2689 Modify how VetKeys are hashed in ic-vetkd-utils #4124
+410
−273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randombit
force-pushed
the
jack/crp-2705
branch
from
729038b to
c371d99
Compare
With this change the Rust library agrees with the TypeScript implementation currently under development, both in terms of algorithms used (XMD for everything possible, with SHAKE-256 for IBE message masking) and the general API structure.
altkdf
reviewed
Feb 27, 2025
fspreiss
reviewed
Feb 28, 2025
fspreiss
reviewed
Feb 28, 2025
randombit
changed the title
|
We're going to change some things to better handle WebCrypto integration, so this PR is on hold until the TS library is updated accordingly. Then I'll again update here to (again) sync the Rust implementation with what is implemented in the TS library. |
fspreiss
reviewed
Mar 20, 2025
fspreiss
reviewed
Mar 20, 2025
fspreiss
reviewed
Mar 20, 2025
altkdf
approved these changes
Mar 20, 2025
fspreiss
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change the Rust library agrees with the TypeScript implementation currently under development, both in terms of algorithms used (XMD for everything possible, with SHAKE-256 for IBE message masking) and the general API structure.