Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass ic-ref-test directly #4515

Merged
merged 2 commits into from
Mar 26, 2025
Merged

fix: Pass ic-ref-test directly #4515

merged 2 commits into from
Mar 26, 2025

Conversation

Bownairo
Copy link
Member

In #3508 we change the name of the underlying ic-ref-test binary, but keep the target the same. This breaks tests that have been depending on the binary name directly.

This change uses the target path to reference the binary, instead.

@Bownairo Bownairo requested review from a team as code owners March 25, 2025 23:11
@github-actions github-actions bot added the fix label Mar 25, 2025
@Bownairo Bownairo added this pull request to the merge queue Mar 26, 2025
Merged via the queue into master with commit ed71f86 Mar 26, 2025
21 checks passed
@Bownairo Bownairo deleted the eero/cleanup-ref-test branch March 26, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants